Add building and container recipes#33
Closed
zhangrongchuan wants to merge 1 commit intoSimulation-Software-Engineering:mainfrom
Closed
Add building and container recipes#33zhangrongchuan wants to merge 1 commit intoSimulation-Software-Engineering:mainfrom
zhangrongchuan wants to merge 1 commit intoSimulation-Software-Engineering:mainfrom
Conversation
MakisH
reviewed
Apr 11, 2026
MakisH
left a comment
MakisH
left a comment
There was a problem hiding this comment.
Generally, everything looks good here and works, thanks! Make sure to not push generated files to the repository.
There was a problem hiding this comment.
I would not include the build/ directory in the repository.
|
|
||
| # ---- deal.II ---- | ||
| find_package(deal.II REQUIRED HINTS /usr/lib/cmake/deal.II) | ||
| DEAL_II_INITIALIZE_CACHED_VARIABLES() |
There was a problem hiding this comment.
FYI, in CMake, lowercase and uppercase are equivalent.
There was a problem hiding this comment.
I would not include binaries in the repository.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(GitLab username: rongchzg)
✔ Features Included
🔹 CMake configuration
target_link_librariesto avoid keyword conflicts with deal.II🔹 Docker environment
cmake ..,make,make install,ldconfigrm -rf build main)✔ Implemented Modules
flatset/(Boost.Container)filesystem/(Boost.Filesystem)fem/(deal.II Poisson solver)yamlParser/(yaml-cpp parsing)✔ Runtime Verification
Inside the container:
docker run -it cmake-exercise cd cmake-exercise ./build_and_run.sh